Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eks-v2-alpha): remove nested stack #32692

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xazhao
Copy link
Contributor

@xazhao xazhao commented Dec 30, 2024

Reason for this change

In the current EKS module, kubectlProvider is created in a nested stack. The nested stack here is not necessary and hence moving it to the main stack.

Description of changes

Move kubectlProvider to the main stack.

Describe any new or updated permissions being added

<!— What new or updated IAM permissions are needed to support the changes being introduced ? -->

Description of how you validated changes

Updated unit tests so they all passed

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Dec 30, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 30, 2024 22:08
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.95%. Comparing base (6c790fd) to head (da25112).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32692   +/-   ##
=======================================
  Coverage   66.95%   66.95%           
=======================================
  Files         329      329           
  Lines       18662    18662           
  Branches     3257     3257           
=======================================
  Hits        12496    12496           
  Misses       5839     5839           
  Partials      327      327           
Flag Coverage Δ
suite.unit 66.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.71% <ø> (ø)
packages/aws-cdk-lib/core 82.08% <ø> (ø)

@xazhao xazhao force-pushed the eks-remove-nested-stack branch from e41cb16 to 12ecc13 Compare December 30, 2024 22:39
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 12ecc13
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants