chore(prlint): fail prlinter on codecov failures, with exemption label #32674
+88
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
commented
Dec 27, 2024
| projectPackages: await this.codecovProjectPackagesAwsCdkSucceeded(sha), | ||
| }; | ||
|
|
||
| validationCollector.validateRuleSet({ |
There was a problem hiding this comment.
this will always fail at the start because the codecov reports take time to be generated. not sure how bad that is yet.
kaizencc
commented
Dec 27, 2024
| @@ -24,6 +25,7 @@ enum Exemption { | |||
| CLI_INTEG_TESTED = 'pr-linter/cli-integ-tested', | |||
| REQUEST_CLARIFICATION = 'pr/reviewer-clarification-requested', | |||
| REQUEST_EXEMPTION = 'pr-linter/exemption-requested', | |||
| CODECOV = "pr-linter/exempt-codecov", | |||
There was a problem hiding this comment.
I think one exemption for all 4 codecovs should be fine for now...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32674 +/- ##
=======================================
Coverage 80.64% 80.64%
=======================================
Files 107 107
Lines 6994 6994
Branches 1290 1290
=======================================
Hits 5640 5640
Misses 1175 1175
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current process for codecov statuses is that they block the merge of a PR if the are failing. This PR attempts to move this failure further forward in the PR process, so that the PRlinter fails and alerts the author. It also means that we can include an exemption label to merge a PR that we allow to be in breach of the codecov report. Currently, to do so we must change the branch protection rules.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license