Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ec2): add missing instance types and sizes #32658

Merged
merged 7 commits into from
Jan 2, 2025

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Dec 26, 2024

Issue # (if applicable)

None that I could find

Reason for this change

Update the CDK EC2 instance class and size enums to match the current availability

Description of changes

Added the missing instance classes and sizes

Describe any new or updated permissions being added

None

Description of how you validated change

UsedDescribeInstanceTypes API command in multiple regions (us-east-1, us-east-2, us-west-1, eu-west-1,) and compared the results to the classes and sizes available in the CDK. Again, the union of us-east-1 and us-east-2 should cover all possible instance classes and sizes.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 26, 2024 11:39
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.96%. Comparing base (efe7c2e) to head (477702c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32658   +/-   ##
=======================================
  Coverage   66.96%   66.96%           
=======================================
  Files         329      329           
  Lines       18663    18663           
  Branches     3258     3258           
=======================================
  Hits        12497    12497           
  Misses       5839     5839           
  Partials      327      327           
Flag Coverage Δ
suite.unit 66.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.71% <ø> (ø)
packages/aws-cdk-lib/core 82.08% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 26, 2024
@nmussy nmussy changed the title chore(ec2): add missing instance types and size chore(ec2): add missing instance types and sizes Dec 26, 2024
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Dec 27, 2024
godwingrs22
godwingrs22 previously approved these changes Dec 31, 2024
Copy link
Contributor

mergify bot commented Dec 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Dec 31, 2024

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 31, 2024
Copy link
Contributor

mergify bot commented Dec 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@godwingrs22
Copy link
Member

@Mergifyio update

Copy link
Contributor

mergify bot commented Dec 31, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov.yml without workflows permission

@nmussy
Copy link
Contributor Author

nmussy commented Dec 31, 2024

Want me to update the repo manually?

@godwingrs22
Copy link
Member

Want me to update the repo manually?

Yes, please help to update the PR manually. Thanks.

@mergify mergify bot dismissed godwingrs22’s stale review December 31, 2024 18:19

Pull request has been modified.

godwingrs22
godwingrs22 previously approved these changes Dec 31, 2024
Copy link
Contributor

mergify bot commented Dec 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Dec 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jan 1, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #32658 has been dequeued. The pull request has been synchronized by a user

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot dismissed godwingrs22’s stale review January 1, 2025 10:20

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 1, 2025
@nmussy
Copy link
Contributor Author

nmussy commented Jan 2, 2025

Let me know if there's anything I can do on my end, but the maintainers should already have edit perms

@godwingrs22
Copy link
Member

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Jan 2, 2025

requeue

☑️ This pull request is already queued

@godwingrs22
Copy link
Member

@Mergifyio update

Copy link
Contributor

mergify bot commented Jan 2, 2025

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 477702c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 721e700 into aws:main Jan 2, 2025
21 checks passed
Copy link

github-actions bot commented Jan 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants