Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Node 16 #237

Merged
merged 1 commit into from
Jun 12, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Switch to Node 16
ottokruse committed Jun 12, 2023
commit 0e1de7fb2dcce7aa4dfbeb13df784c5995c6d48d
32 changes: 16 additions & 16 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -16,12 +16,12 @@
"keywords": [],
"author": "",
"devDependencies": {
"@tsconfig/node14": "^1.0.1",
"@tsconfig/node16": "^1.0.4",
"@types/adm-zip": "^0.4.34",
"@types/aws-lambda": "^8.10.92",
"@types/cookie": "^0.4.1",
"@types/fs-extra": "^9.0.13",
"@types/node": "^18.15.12",
"@types/node": "^20.2.5",
"aws-sdk": "^2.1354.0",
"html-loader": "^3.1.0",
"prettier": "^2.5.1",
6 changes: 6 additions & 0 deletions src/cfn-custom-resources/react-app/index.ts
Original file line number Diff line number Diff line change
@@ -93,6 +93,12 @@ async function buildSpa(config: Configuration) {
console.log(`Creating React environment file ${temp_dir}/.env ...`);
writeFileSync(`${temp_dir}/.env`, reactEnv);

console.log("NPM version:");
execSync("npm -v", {
cwd: temp_dir,
stdio: "inherit",
env: { ...process.env, HOME: home_dir },
});
console.log(`Installing dependencies to build React app in ${temp_dir} ...`);
execSync("npm ci", {
cwd: temp_dir,
5 changes: 4 additions & 1 deletion template.yaml
Original file line number Diff line number Diff line change
@@ -290,7 +290,7 @@ Globals:
- ApplyPermissionsBoundary
- !Ref PermissionsBoundaryPolicyArn
- !Ref AWS::NoValue
Runtime: nodejs14.x
Runtime: nodejs16.x

Resources:
S3Bucket:
@@ -827,6 +827,7 @@ Resources:
- !Ref OAuthScopes
SignOutUrl: !Ref SignOutUrl
CookieSettings: !Ref CookieSettings
Version: !Ref Version

ReactAppHandler:
Type: AWS::Serverless::Function
@@ -836,6 +837,8 @@ Resources:
Handler: index.handler
Timeout: 300
MemorySize: 3008
EphemeralStorage:
Size: 2048
Policies:
- Version: "2012-10-17"
Statement:
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node14",
"extends": "@tsconfig/node16",
"include": [
/* Specify files to transpile explicitly because other ts files in this project are transpiled directly by webpack */
"src/cfn-custom-resources"