-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jupyterhub to management cluster #173
base: main
Are you sure you want to change the base?
Conversation
To test, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zjaco13 This is AWSome work. I have a minor feedback on the approach. we have tomove the install to aiml.tf
so people get this only when they optin aiml. Follow are the reqs for merging this PR:
- Get the recommended approach updated
- Get @hmuthusamy run this and confirm this works in this PR
- Get the instructions of this section added to
AIML Delivery
module of our workshop.
Tested by @hmuthusamy, will work on instructions next |
@elamaran11 Validated the changes locally in a new setup. Works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
platform/infra/terraform/mgmt/terraform/templates/argocd-apps/jupyterhub.yaml
Outdated
Show resolved
Hide resolved
@hmuthusamy Thanks for the test, @zjaco13 Everything looks great, once we have the instructions in the workshop build, i will merge this. |
@zjaco13 Everything works fine but noticed when cleaning up, the jupyterhub helm chart creates a ELB for proxy service set on values yaml (Values.proxy.service.type “LoadBalancer” ). Do we need this or we can use the existing domain? |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.