Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyterhub to management cluster #173

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add jupyterhub to management cluster #173

wants to merge 15 commits into from

Conversation

zjaco13
Copy link
Contributor

@zjaco13 zjaco13 commented Dec 30, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zjaco13
Copy link
Contributor Author

zjaco13 commented Dec 30, 2024

To test, run setup-environments-local.sh, then in argocd switch kyverno-pss-policies-enforce-exceptions to track from this branch. Login at DOMAIN/jupyterhub with keycloak to start a session as user1

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zjaco13 This is AWSome work. I have a minor feedback on the approach. we have tomove the install to aiml.tf so people get this only when they optin aiml. Follow are the reqs for merging this PR:

  1. Get the recommended approach updated
  2. Get @hmuthusamy run this and confirm this works in this PR
  3. Get the instructions of this section added to AIML Delivery module of our workshop.

platform/infra/terraform/mgmt/terraform/jupyterhub.tf Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@zjaco13
Copy link
Contributor Author

zjaco13 commented Jan 2, 2025

@zjaco13 This is AWSome work. I have a minor feedback on the approach. we have tomove the install to aiml.tf so people get this only when they optin aiml. Follow are the reqs for merging this PR:

1. Get the recommended approach updated

2. Get @hmuthusamy run this and confirm this works in this PR

3. Get the instructions of this section added to `AIML Delivery` module of our workshop.

Tested by @hmuthusamy, will work on instructions next

@hmuthusamy
Copy link
Contributor

@zjaco13 This is AWSome work. I have a minor feedback on the approach. we have tomove the install to aiml.tf so people get this only when they optin aiml. Follow are the reqs for merging this PR:

1. Get the recommended approach updated

2. Get @hmuthusamy run this and confirm this works in this PR

3. Get the instructions of this section added to `AIML Delivery` module of our workshop.

@elamaran11 Validated the changes locally in a new setup. Works fine.
Screenshot 2025-01-02 at 4 49 33 PM

Copy link
Contributor

@hmuthusamy hmuthusamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.gitignore Show resolved Hide resolved
@elamaran11
Copy link
Contributor

@hmuthusamy Thanks for the test, @zjaco13 Everything looks great, once we have the instructions in the workshop build, i will merge this.

@hmuthusamy
Copy link
Contributor

@zjaco13 Everything works fine but noticed when cleaning up, the jupyterhub helm chart creates a ELB for proxy service set on values yaml (Values.proxy.service.type “LoadBalancer” ). Do we need this or we can use the existing domain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants