This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Encrypt root device #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubikusss
approved these changes
Nov 18, 2021
sshvans
suggested changes
Nov 18, 2021
templates/storage.template.yaml
Outdated
| - Effect: Allow | ||
| Action: | ||
| - 'kms:DescribeKey' | ||
| Resource: !Sub 'arn:${AWS::Partition}:kms:*:*:*' |
There was a problem hiding this comment.
Can we restrict to a specific kms resource?
There was a problem hiding this comment.
I had misread the documentation about the File Share encryption. It's default behavior is to use server-side encryption with an S3-Managed key. Changing this with another default key doesn't really add value so we decided to remove it.
sshvans
approved these changes
Nov 19, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #33,
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.