-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Karpenter Add-on][BREAKING CHANGE] Update for v0.34.0 #940
Conversation
@youngjeong46 Nice PR, lof of work. Does this also fix #859 and #893 Issues? |
No, not yet. I'm trying to figure out the exact ask (at least for 893). Given this PR, it would most likely be a fast follow (along with 0.35 update that came out last night). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youngjeong46 tremendous work, a lot of changes and new features.
Please see my review comments. I will then kick off a test on 1.28. The move the default EKS version to 1.29 in a separate PR and retest before release on 1.29.
Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my last comment, I will kick off e2e once addressed since code changes invalidate the e2e approval.
/do-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end to end tests failed. A maintainer can provide more details.
@youngjeong46 getting failure on jest test: FAIL test/karpenter.test.ts214 | ● Test suite failed to run |
/do-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end to end tests passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #, if available: #924
Description of changes:
This PR changes the Karpenter add-on to support up to v0.34.0 (v0.35.0 just released as of the day of the PR, so it will be following as another PR). This is considered a breaking change:
consolidation
with v1beta1 CRDs ordisruption
with v1alpha5 CRDs)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.