feat: allow ip detector to exclude certain ip addresses #28
Conversation
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1278984 |
| @@ -44,6 +44,9 @@ List<InetAddress> getIpAddresses(Enumeration<NetworkInterface> interfaces, Confi | |||
|
|
|||
| for (InterfaceAddress interfaceAddress : networkInterface.getInterfaceAddresses()) { | |||
| InetAddress address = interfaceAddress.getAddress(); | |||
| if (config.getExcludedIPAddresses().contains(address.getHostAddress())) { | |||
There was a problem hiding this comment.
just a heads up this is running in a different thread than config changes, so there's technically some interleaving here when new config is cleared/set
There was a problem hiding this comment.
and by heads up i mean, lets address it :) the worst case (although unlikely) means that connectivity info will be published with excluded ips for bit
There was a problem hiding this comment.
I'm not too concerned about this issue, because when IP Detector is deployed, the config merge happens before its startup lifecycle. When IP detector goes into startup, it should already have the deployed excluded-ip config.
We do not have any use case for its config update outside deployments as of today, since component itself does not update it and other components are not allowed to update it.
There was a problem hiding this comment.
but what about deployments that are just config updates? these exclusions wouldn't change? even if not, there's still the mental overhead of having to justify why the race condition isn't an issue
junfuchen99
force-pushed
the
exclude-ips
branch
from
0ac979e
to
1278984
Compare
Description of changes:
excludedIPAddressesto exclude some ip addresses from ip detector.Why is this change necessary:
Give customer granular controls over which IP addresses to detect and upload to cloud.
How was this change tested:
Unit test and manual test.
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.