#P39046999 Persist last (5) successful local deployments as part of CLI application code #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is not successful, please address the errors. |
MikeDombo
previously approved these changes
Nov 23, 2022
|
Build is not successful. You must fix your commit messages |
…plication code (#P39046999)
…plication code (#P39046999)
|
Client Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against f89da2a |
|
Server Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against f89da2a |
MikeDombo
reviewed
Nov 29, 2022
| @@ -180,6 +185,27 @@ public void persistLocalDeployment(Topics serviceConfig, Map<String, Object> dep | |||
| Topics localDeploymentDetails = localDeployments.lookupTopics(deploymentId); | |||
| localDeploymentDetails.replaceAndWait(deploymentDetails); | |||
| // TODO: [P41178971]: Implement a limit on no of local deployments to persist status for | |||
There was a problem hiding this comment.
remove the TODO, this has been resolved now.
MikeDombo
reviewed
Nov 29, 2022
Comment on lines
561
to
563
| } catch (InterruptedException e) { | ||
| throw new RuntimeException(e); | ||
| } |
There was a problem hiding this comment.
do not catch in tests, just let the test method throw InterruptedException
MikeDombo
reviewed
Nov 29, 2022
| } | ||
| cliEventStreamAgent.persistLocalDeployment(cliServiceConfig, localDeploymentDetails.convertToMapOfObject()); | ||
| // to ensure topic add as order | ||
| Thread.sleep(1000); |
There was a problem hiding this comment.
this is going to slow things down, just sleep 1ms and use context.waitForPublishQueueToClear() after sleeping
added 2 commits
November 30, 2022 10:18
…plication code (#P39046999)
messages fixed |
MikeDombo
reviewed
Dec 13, 2022
| List<Topics> childrenToRemove = new ArrayList<>(); | ||
| AtomicInteger deploymentSucceeded = new AtomicInteger(); | ||
| localDeployments.forEach(topics -> { | ||
| Topics deploymentTopics = (Topics) topics; |
There was a problem hiding this comment.
check using instanceof before blindly casting to Topics.
Comment on lines
193
to
194
| Topic existingChild = deploymentTopics.find(DEPLOYMENT_STATUS_KEY_NAME); | ||
| String value = existingChild.getOnce().toString(); |
There was a problem hiding this comment.
use Coerce.toString(deploymentTopics.find(DEPLOYMENT_STATUS_KEY_NAME)
| // if more than PERSIST_LIMIT deployments are success, remove until PERSIST_LIMIT left | ||
| if (deploymentSucceeded.get() > PERSIST_LIMIT) { | ||
| childrenToRemove.stream() | ||
| .sorted(Comparator.comparingLong(t -> t.find(DEPLOYMENT_STATUS_KEY_NAME).getModtime())) |
There was a problem hiding this comment.
find may return null, you must handle this correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.