Skip to content

Commit

Permalink
Update to ACK runtime v0.39.0, code-generator v0.39.1 (#127)
Browse files Browse the repository at this point in the history 
### Update to ACK runtime `v0.39.0`, code-generator `v0.39.1`

----------

* ACK code-generator `v0.39.1` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.39.1)
* ACK runtime `v0.39.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.39.0)

----------

NOTE:
This PR increments the release version of service controller from `v1.0.17` to `v1.0.18`

Once this PR is merged, release `v1.0.18` will be automatically created for `applicationautoscaling-controller`

**Please close this PR, if you do not want the new patch release for `applicationautoscaling-controller`**

----------

#### stdout for `make build-controller`:

```
building ack-generate ... ok.
==== building applicationautoscaling-controller ====
Copying common custom resource definitions into applicationautoscaling
Building Kubernetes API objects for applicationautoscaling
Generating deepcopy code for applicationautoscaling
Generating custom resource definitions for applicationautoscaling
Building service controller for applicationautoscaling
Generating RBAC manifests for applicationautoscaling
Running gofmt against generated code for applicationautoscaling
Updating additional GitHub repository maintenance files
==== building applicationautoscaling-controller release artifacts ====
Building release artifacts for applicationautoscaling-v1.0.18
Generating common custom resource definitions
Generating custom resource definitions for applicationautoscaling
Generating RBAC manifests for applicationautoscaling
```

----------

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • Loading branch information
@ack-bot
ack-bot authored Oct 12, 2024
1 parent e32bf89 commit 96ecc1e
Show file tree
Hide file tree
Showing 18 changed files with 130 additions and 432 deletions.
8 changes: 4 additions & 4 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ack_generate_info:
build_date: "2024-08-29T17:00:59Z"
build_hash: f8f98563404066ac3340db0a049d2e530e5c51cc
go_version: go1.22.5
version: v0.38.1
build_date: "2024-10-10T04:00:07Z"
build_hash: 36c2d234498c2bc4f60773ab8df632af4067f43b
go_version: go1.23.2
version: v0.39.1
api_directory_checksum: 4064c75a2b25943f3824149c2f4f31013738113e
api_version: v1alpha1
aws_sdk_go_version: v1.44.93
Expand Down
2 changes: 1 addition & 1 deletion config/controller/kustomization.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ kind: Kustomization
images:
- name: controller
newName: public.ecr.aws/aws-controllers-k8s/applicationautoscaling-controller
newTag: 1.0.17
newTag: 1.0.18
48 changes: 1 addition & 47 deletions config/crd/bases/applicationautoscaling.services.k8s.aws_scalabletargets.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.14.0
controller-gen.kubebuilder.io/version: v0.16.2
name: scalabletargets.applicationautoscaling.services.k8s.aws
spec:
group: applicationautoscaling.services.k8s.aws
Expand Down Expand Up @@ -40,7 +40,6 @@ spec:
description: |-
ScalableTargetSpec defines the desired state of ScalableTarget.
Represents a scalable target.
properties:
maxCapacity:
Expand All @@ -50,7 +49,6 @@ spec:
maximum capacity limit in response to changing demand. This property is required
when registering a new scalable target.
Although you can specify a large maximum capacity, note that service quotas
may impose lower limits. Each service has its own default quotas for the
maximum capacity of the resource. If you want to specify a higher limit,
Expand All @@ -67,7 +65,6 @@ spec:
the minimum capacity limit in response to changing demand. This property
is required when registering a new scalable target.
For certain resources, the minimum value allowed is 0. This includes Lambda
provisioned concurrency, Spot Fleet, ECS services, Aurora DB clusters, EMR
clusters, and custom resources. For all other resources, the minimum value
Expand All @@ -79,71 +76,55 @@ spec:
The identifier of the resource that is associated with the scalable target.
This string consists of the resource type and unique identifier.
* ECS service - The resource type is service and the unique identifier
is the cluster name and service name. Example: service/default/sample-webapp.
* Spot Fleet - The resource type is spot-fleet-request and the unique
identifier is the Spot Fleet request ID. Example: spot-fleet-request/sfr-73fbd2ce-aa30-494c-8788-1cee4EXAMPLE.
* EMR cluster - The resource type is instancegroup and the unique identifier
is the cluster ID and instance group ID. Example: instancegroup/j-2EEZNYKUA1NTV/ig-1791Y4E1L8YI0.
* AppStream 2.0 fleet - The resource type is fleet and the unique identifier
is the fleet name. Example: fleet/sample-fleet.
* DynamoDB table - The resource type is table and the unique identifier
is the table name. Example: table/my-table.
* DynamoDB global secondary index - The resource type is index and the
unique identifier is the index name. Example: table/my-table/index/my-table-index.
* Aurora DB cluster - The resource type is cluster and the unique identifier
is the cluster name. Example: cluster:my-db-cluster.
* SageMaker endpoint variant - The resource type is variant and the unique
identifier is the resource ID. Example: endpoint/my-end-point/variant/KMeansClustering.
* Custom resources are not supported with a resource type. This parameter
must specify the OutputValue from the CloudFormation template stack used
to access the resources. The unique identifier is defined by the service
provider. More information is available in our GitHub repository (https://github.com/aws/aws-auto-scaling-custom-resource).
* Amazon Comprehend document classification endpoint - The resource type
and unique identifier are specified using the endpoint ARN. Example: arn:aws:comprehend:us-west-2:123456789012:document-classifier-endpoint/EXAMPLE.
* Amazon Comprehend entity recognizer endpoint - The resource type and
unique identifier are specified using the endpoint ARN. Example: arn:aws:comprehend:us-west-2:123456789012:entity-recognizer-endpoint/EXAMPLE.
* Lambda provisioned concurrency - The resource type is function and the
unique identifier is the function name with a function version or alias
name suffix that is not $LATEST. Example: function:my-function:prod or
function:my-function:1.
* Amazon Keyspaces table - The resource type is table and the unique identifier
is the table name. Example: keyspace/mykeyspace/table/mytable.
* Amazon MSK cluster - The resource type and unique identifier are specified
using the cluster ARN. Example: arn:aws:kafka:us-east-1:123456789012:cluster/demo-cluster-1/6357e0b2-0e6a-4b86-a0b4-70df934c2e31-5.
* Amazon ElastiCache replication group - The resource type is replication-group
and the unique identifier is the replication group name. Example: replication-group/mycluster.
* Neptune cluster - The resource type is cluster and the unique identifier
is the cluster name. Example: cluster:mycluster.
type: string
Expand All @@ -153,7 +134,6 @@ spec:
roles (such as Amazon EMR), and it must specify the ARN of an IAM role that
allows Application Auto Scaling to modify the scalable target on your behalf.
If the service supports service-linked roles, Application Auto Scaling uses
a service-linked role, which it creates if it does not yet exist. For more
information, see Application Auto Scaling IAM roles (https://docs.aws.amazon.com/autoscaling/application/userguide/security_iam_service-with-iam.html#security_iam_service-with-iam-roles).
Expand All @@ -163,84 +143,64 @@ spec:
The scalable dimension associated with the scalable target. This string consists
of the service namespace, resource type, and scaling property.
* ecs:service:DesiredCount - The desired task count of an ECS service.
* elasticmapreduce:instancegroup:InstanceCount - The instance count of
an EMR Instance Group.
* ec2:spot-fleet-request:TargetCapacity - The target capacity of a Spot
Fleet.
* appstream:fleet:DesiredCapacity - The desired capacity of an AppStream
2.0 fleet.
* dynamodb:table:ReadCapacityUnits - The provisioned read capacity for
a DynamoDB table.
* dynamodb:table:WriteCapacityUnits - The provisioned write capacity for
a DynamoDB table.
* dynamodb:index:ReadCapacityUnits - The provisioned read capacity for
a DynamoDB global secondary index.
* dynamodb:index:WriteCapacityUnits - The provisioned write capacity for
a DynamoDB global secondary index.
* rds:cluster:ReadReplicaCount - The count of Aurora Replicas in an Aurora
DB cluster. Available for Aurora MySQL-compatible edition and Aurora PostgreSQL-compatible
edition.
* sagemaker:variant:DesiredInstanceCount - The number of EC2 instances
for an SageMaker model endpoint variant.
* custom-resource:ResourceType:Property - The scalable dimension for a
custom resource provided by your own application or service.
* comprehend:document-classifier-endpoint:DesiredInferenceUnits - The
number of inference units for an Amazon Comprehend document classification
endpoint.
* comprehend:entity-recognizer-endpoint:DesiredInferenceUnits - The number
of inference units for an Amazon Comprehend entity recognizer endpoint.
* lambda:function:ProvisionedConcurrency - The provisioned concurrency
for a Lambda function.
* cassandra:table:ReadCapacityUnits - The provisioned read capacity for
an Amazon Keyspaces table.
* cassandra:table:WriteCapacityUnits - The provisioned write capacity
for an Amazon Keyspaces table.
* kafka:broker-storage:VolumeSize - The provisioned volume size (in GiB)
for brokers in an Amazon MSK cluster.
* elasticache:replication-group:NodeGroups - The number of node groups
for an Amazon ElastiCache replication group.
* elasticache:replication-group:Replicas - The number of replicas per
node group for an Amazon ElastiCache replication group.
* neptune:cluster:ReadReplicaCount - The count of read replicas in an
Amazon Neptune DB cluster.
type: string
Expand All @@ -257,22 +217,17 @@ spec:
to true suspends the specified scaling activities. Setting it to false (default)
resumes the specified scaling activities.
Suspension Outcomes
* For DynamicScalingInSuspended, while a suspension is in effect, all
scale-in activities that are triggered by a scaling policy are suspended.
* For DynamicScalingOutSuspended, while a suspension is in effect, all
scale-out activities that are triggered by a scaling policy are suspended.
* For ScheduledScalingSuspended, while a suspension is in effect, all
scaling activities that involve scheduled actions are suspended.
For more information, see Suspending and resuming scaling (https://docs.aws.amazon.com/autoscaling/application/userguide/application-auto-scaling-suspend-resume-scaling.html)
in the Application Auto Scaling User Guide.
properties:
Expand Down Expand Up @@ -305,7 +260,6 @@ spec:
when it has verified that an "adopted" resource (a resource where the
ARN annotation was set by the Kubernetes user on the CR) exists and
matches the supplied CR's Spec field values.
TODO(vijat@): Find a better strategy for resources that do not have ARN in CreateOutputResponse
https://github.com/aws/aws-controllers-k8s/issues/270
type: string
ownerAccountID:
Expand Down
Loading

0 comments on commit 96ecc1e

Please sign in to comment.