Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useLocationsView hook #5908

Open
wants to merge 6 commits into
base: feat-storage-browser/main
Choose a base branch
from

Conversation

pranavosu
Copy link
Member

@pranavosu pranavosu commented Oct 16, 2024

Description of changes

Refactor LocationsView based the WIP Hooks Api Doc.

Doesn't implement everything yet, like options for the hook but supports everything we have currently.

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 726b546

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines 35 to 36
| { type: 'paginate-next' }
| { type: 'paginate-previous' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking on this change a bit more think we will need to provide a single paginate action:

// where page is the target page
{ type: 'paginate'; page: number }

to allow for consuming UI components to receive a single onPaginate prop, which enables custom Paginate components to render with more than two buttons

@pranavosu pranavosu marked this pull request as ready for review October 18, 2024 00:59
@pranavosu pranavosu requested a review from a team as a code owner October 18, 2024 00:59
useLocationsDataSpy.mockReturnValue(nextPageState);

// go forward
await act(async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't have to add act here -- but we have this issue in the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants