feat(ai): add message renderer #5873
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2dd9988 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thaddmt
approved these changes
Oct 9, 2024
reesscot
previously approved these changes
Oct 17, 2024
| @@ -54,6 +55,11 @@ export interface AIConversation { | |||
|
|
|||
| export type MessageVariant = 'bubble' | 'default'; | |||
|
|
|||
| export interface MessageRenderer { | |||
| text?: (message: string) => React.JSX.Element; | |||
There was a problem hiding this comment.
Would it make sense to expand the function definition here to allow an object so additional key/values can be included in the future?
// example
text?: (text: { content: string )) => React.JSX.Element;
calebpollman
previously approved these changes
Oct 17, 2024
dbanksdesign
dismissed stale reviews from calebpollman and reesscot
via
b329b77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds the ability to define message renderer functions for text and images so that customers can render markdown without us taking a dependency on a markdown renderer.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.