chore(ai): add theming for AIConversation #5827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8b64b46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
examples/next/pages/ui/components/ai/ai-conversation-theming-v2/index.page.tsx
Fixed
Show fixed
Hide fixed
examples/next/pages/ui/components/ai/ai-conversation-theming/index.page.tsx
Fixed
Show fixed
Hide fixed
reesscot
reviewed
Oct 10, 2024
| }, | ||
|
|
||
| image: { | ||
| width: { value: '{fontSizes.medium.value}' }, |
There was a problem hiding this comment.
Why would the image size match the font sizes?
There was a problem hiding this comment.
The image here is the image inside the attachment so we want it to be the size of the font size:
reesscot
reviewed
Oct 10, 2024
examples/next/pages/ui/components/ai/ai-conversation-theming-v2/index.page.tsx
Outdated
Show resolved
Hide resolved
examples/next/pages/ui/components/ai/ai-conversation-theming-v2/index.page.tsx
Outdated
Show resolved
Hide resolved
examples/next/pages/ui/components/ai/ai-conversation-theming-v2/index.page.tsx
Show resolved
Hide resolved
calebpollman
approved these changes
Oct 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds design token support and component theme support for AIConversation
Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.