Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update and remove gem dependency webrick #3884

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

phantumcode
Copy link
Member

@phantumcode phantumcode commented Sep 23, 2024

Issue #

Description

Updating and remove gem dependency webrick

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner September 23, 2024 21:20
@phantumcode phantumcode changed the title chore: update canaries gem dependencies chore: update gem webrick to 1.8.1 Sep 23, 2024
@phantumcode phantumcode changed the title chore: update gem webrick to 1.8.1 chore: Update and remove gem dependency webrick Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.19%. Comparing base (f061a41) to head (7e124d9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3884      +/-   ##
==========================================
+ Coverage   68.00%   68.19%   +0.19%     
==========================================
  Files        1087     1087              
  Lines       38118    38118              
==========================================
+ Hits        25922    25995      +73     
+ Misses      12196    12123      -73     
Flag Coverage Δ
API_plugin_unit_test 69.35% <ø> (+0.21%) ⬆️
AWSPluginsCore 68.50% <ø> (ø)
Amplify 46.94% <ø> (+0.02%) ⬆️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.25% <ø> (-0.10%) ⬇️
DataStore_plugin_unit_test 82.39% <ø> (+1.08%) ⬆️
Geo_plugin_unit_test 72.06% <ø> (ø)
Logging_plugin_unit_test 62.99% <ø> (ø)
Predictions_plugin_unit_test 35.94% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 75.46% <ø> (ø)
unit_tests 68.19% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phantumcode phantumcode merged commit 42c97ba into main Sep 23, 2024
80 checks passed
@phantumcode phantumcode deleted the chore/canaries_update_gem branch September 23, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants