Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(predictions): region handling for creating correct streaming endpoint from region #3880

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

ppraja22
Copy link
Contributor

@ppraja22 ppraja22 commented Sep 20, 2024

Issue #

None

Description

We need to construct the correct streaming endpoint with correct base domain depending on the regions. Not all region belong to commercial partition so the base domain becomes different. We can keep adding new regions in this check to get the desired base domain in future.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ppraja22 ppraja22 requested a review from a team as a code owner September 20, 2024 07:11
@thisisabhash thisisabhash changed the title fix(service endpoint): Added region handling for creating correct streaming endpoint from region fix(predictions): region handling for creating correct streaming endpoint from region Sep 20, 2024
@thisisabhash thisisabhash merged commit 6b301f0 into aws-amplify:main Sep 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants