Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AppSync components #3825

Merged
merged 6 commits into from
Aug 23, 2024
Merged

feat: Add AppSync components #3825

merged 6 commits into from
Aug 23, 2024

Conversation

lawmicha
Copy link
Member

@lawmicha lawmicha commented Aug 20, 2024

Issue #

Description

This PR adds the following public APIs to facilitate connectivity with AppSync.

AppSync signer

Extension on AWSCognitoAuthPlugin to provide a static method to sign AppSync requests. This API receives an URLRequest and returns a signed URLRequest.

AWSAppSync configuration

A new type vended from AWSPluginsCore as AWSAppSyncConfiguration. This configuration has the functionality to read amplify_outputs.json similar to Amplify.configure(with: amplifyOutputs) and provide properties related to AppSync endpoint configuration such as region, endpoint, apiKey.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested a review from a team as a code owner August 20, 2024 19:57
Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

1 similar comment
Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

5d
5d previously approved these changes Aug 21, 2024
Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

@lawmicha lawmicha merged commit 673a075 into main Aug 23, 2024
@lawmicha lawmicha deleted the lawmicha.apollo branch August 23, 2024 16:35
@atierian
Copy link
Member

API BR approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants