Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix issue closed Action #3813

Merged
merged 1 commit into from
Aug 14, 2024
Merged

chore: Fix issue closed Action #3813

merged 1 commit into from
Aug 14, 2024

Conversation

tylerjroach
Copy link
Member

Issue #

Description

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach requested a review from a team as a code owner August 13, 2024 17:48
Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

@ruisebas ruisebas merged commit aeb8d13 into main Aug 14, 2024
79 checks passed
@ruisebas ruisebas deleted the tjroach/fix-gh-action branch August 14, 2024 16:13
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (ca6c65a) to head (c9d85ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3813       +/-   ##
===========================================
+ Coverage   44.79%   80.72%   +35.92%     
===========================================
  Files          95      112       +17     
  Lines        3898     7189     +3291     
===========================================
+ Hits         1746     5803     +4057     
+ Misses       2152     1386      -766     
Flag Coverage Δ
Analytics_plugin_unit_test ?
DataStore_plugin_unit_test 81.23% <ø> (?)
Geo_plugin_unit_test 72.00% <ø> (ø)
Predictions_plugin_unit_test ?
unit_tests 80.72% <ø> (+35.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants