Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Auth) Keychain Sharing (App Reload Required) #3805

Closed
wants to merge 2 commits into from

Conversation

yaroluchko
Copy link

Issue #

#2508
#3277

Description

This allows customers to set the access group they would like the auth session to be shared on. Currently, syncing the auth session required an app restart. More work is required to make sure the auth session gets refreshed automatically within the auth state machine.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yaroluchko yaroluchko changed the title Yaluchko/auth keychain sharing feat(Auth) Keychain Sharing (App Reload Required) Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

API Breakage Report

💔 Public API Breaking Change detected:

Module: AWSPluginsCore
Func KeychainStoreBehavior._getAll() has been added as a protocol requirement

Copy link
Contributor

API Breakage Report

💔 Public API Breaking Change detected:

Module: AWSPluginsCore
Func KeychainStoreBehavior._getAll() has been added as a protocol requirement

* Remove migrateKeychainItemsOfUserSession bool from SecureStoragePreferences
Copy link
Contributor

API Breakage Report

💔 Public API Breaking Change detected:

Module: AWSPluginsCore
Func KeychainStoreBehavior._getAll() has been added as a protocol requirement

@yaroluchko yaroluchko closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants