Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): upgrade dependency rexml version to 3.3.3 #3799

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

5d
Copy link
Member

@5d 5d commented Aug 2, 2024

Issue #

https://github.com/aws-amplify/amplify-swift/security/dependabot/13
https://github.com/aws-amplify/amplify-swift/security/dependabot/14

Description

Upgrade CI dependency gem rexml to >= 3.3.3

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

API Breakage Report

✅ No Public API Breaking Change detected

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.66%. Comparing base (2c3ed0c) to head (95275da).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3799      +/-   ##
==========================================
+ Coverage   68.55%   68.66%   +0.10%     
==========================================
  Files        1080     1080              
  Lines       37700    37700              
==========================================
+ Hits        25845    25886      +41     
+ Misses      11855    11814      -41     
Flag Coverage Δ
API_plugin_unit_test 68.83% <ø> (ø)
AWSPluginsCore 68.67% <ø> (ø)
Amplify 47.36% <ø> (ø)
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.67% <ø> (-0.21%) ⬇️
DataStore_plugin_unit_test 82.31% <ø> (+0.90%) ⬆️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.95% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.81% <ø> (ø)
unit_tests 68.66% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

API Breakage Report

✅ No Public API Breaking Change detected

@ruisebas ruisebas merged commit e41df42 into main Aug 2, 2024
80 checks passed
@ruisebas ruisebas deleted the 5d/upgrade-rexml branch August 2, 2024 13:42
yaroluchko pushed a commit to yaroluchko/amplify-swift-keychain-sharing that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants