Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(analytics): add additional test cases for analytics integration test workflow #3240

Merged
merged 6 commits into from
Sep 29, 2023
Merged

test(analytics): add additional test cases for analytics integration test workflow #3240

merged 6 commits into from
Sep 29, 2023

Conversation

phantumcode
Copy link
Member

Issue #

Description

  • add analytics integration test cases for enabling/disabling plugin and register/unregister global properties

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner September 26, 2023 18:10
@phantumcode
Merge branch 'main' into test/analytics_integration
53dc859 
* main:
  chore(ci): update dependency review config file path (#3233)
  test(logging): add logging plugin integration test (#3218)
  chore: remove unnecessary CloudWatch dependency from logger plugin (#3235)
  chore: Update CHANGELOG.md for 2.18.0 (#3236)
  chore: finalize release 2.18.1 [skip ci]
  chore: release 2.18.1 [skip ci]
  fix(datastore): call errorHandler in Sync operation when failure
@phantumcode phantumcode merged commit b72e79f into main Sep 29, 2023
@phantumcode phantumcode deleted the test/analytics_integration branch September 29, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh62 harsh62 harsh62 approved these changes

@ruisebas ruisebas ruisebas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phantumcode @harsh62 @ruisebas