fix(storage): change default tagging directive to replace #14527
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soberm
changed the title
soberm
requested review from
pranavosu,
Amplifiyer,
avi-karthik and
a team
as code owners
soberm
added
run-tests
ahmedhamouda78
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Changes the default tagging directive for S3
copyoperations to always useREPLACE, preventing permission errors when copying objects using S3 access grants. More specifically:• Updated S3 copyObject call to always use
TaggingDirective: 'REPLACE'• Updated all test expectations to match new behavior
Issue #, if available
#14469
Description of how you validated changes
Unit Tests
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.