Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release(required): Revert "Reapply "feat(core): resolve webcrypto from node:crypto for Node18 (#13599)" (#13775)" #13820

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Sep 17, 2024

Description of changes

Issue #, if available

#13817
#13819

Description of how you validated changes

Couldn't reproduce the build issue with a minimal React and a minimal Angular app.
Reverting this change and release as a patch to unblock the build failures.

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF changed the title release(required): Amplify JS release (#13814) release(required): Revert "Reapply "feat(core): resolve webcrypto from node:crypto for Node18 (#13599)" (#13775)" Sep 17, 2024
@HuiSF HuiSF merged commit 3ef5df5 into release Sep 17, 2024
30 checks passed
@HuiSF HuiSF deleted the hui/chore/revert-node18 branch September 17, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants