Conversation
greyshi
reviewed
Jul 31, 2025
Contributor
greyshi
left a comment
greyshi
left a comment
There was a problem hiding this comment.
Just had one minor comment. Overall looks good, except the two commits you're adding both have the message "initial commit". Can you change the commit messages so they describe what's actually in each commit?
README.md
Outdated
| on: | ||
| push: | ||
| branches: [main, master] | ||
| To automate building your source code, add the step that corresponds to your runtime: |
Contributor
There was a problem hiding this comment.
Each of these runtimes will have varying build tools and steps that will be different between customers. We can instead say: "To automate building your source code, add a build step based on your runtime and build process. Below are two commonly used examples for Node.js and Python"
greyshi
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Edited README, tests, and added example workflow.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.