Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI theme, Updated Windows Dependencies, Code cleanup, Improved debug experience #180

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

gabriel-vanca
Copy link

New UI theme, Updated Windows Dependencies, Code cleanup, Improved debug experience

Please note dependencies for Mac will also need updating.

@awaescher
Copy link
Owner

Would you mind reverting the whitespace changes (tabs/spaces)?

@gabriel-vanca
Copy link
Author

gabriel-vanca commented Sep 5, 2024

Oh, apologies, Visual Studio just changes them automatically when I save a file. Sure, feel free to restore them. Just create an .editorconfig file and set indent_style = tab then run Code Cleanup.

https://github.com/RehanSaeed/EditorConfig/blob/main/.editorconfig

@awaescher
Copy link
Owner

I know how to do this but I won't review the pull request like this.
Don't get me wrong, I find it awesome you want to add something to the app. But I do not plan to go through the 150+ changed files in the GitHub diff.

@gabriel-vanca gabriel-vanca marked this pull request as draft September 5, 2024 20:41
@gabriel-vanca gabriel-vanca force-pushed the master branch 2 times, most recently from afe1e5e to 284fe4b Compare September 5, 2024 21:23
@gabriel-vanca
Copy link
Author

Sure, no worries. My bad for pushing all the whitespace reformat and code reallingment stuff. Well, at least this was a fun opportunity to learn how to do an interactive rebase and remove the 17th last commit :)
Should be fine now. Not entirely sure why the check fails.

@gabriel-vanca gabriel-vanca marked this pull request as ready for review September 5, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants