Conversation
ndim
force-pushed
the
add-version-suffix
branch
2 times, most recently
from
08cf693 to
6e8099e
Compare
Open
ndim
force-pushed
the
add-version-suffix
branch
from
5704b2c to
c631626
Compare
Open
ndim
force-pushed
the
add-version-suffix
branch
11 times, most recently
from
0574156 to
afe2353
Compare
3 tasks
This is a partial fix for #1603.
To allow the "make distcheck" target recipe to succeed, add the generated ChangeLog file to the DISTCLEANFILES variable.
Add m4_pattern_forbid safety net for sp_package_* macros.
My VM with FreeBSD takes a bit more than 1050ms for the 1s sleep, namely about 1072ms. No idea what kind of problem this indicates.
This might address the following build warning/error:
```
D:/a/libserialport/libserialport/windows.c: In function 'get_port_details':
D:/a/libserialport/libserialport/windows.c:457:83: error: '%s' directive output may be truncated writing up to 31 bytes into a region of size between 20 and 31 [-Werror=format-truncation=]
457 | snprintf(usb_path, sizeof(usb_path), "%d%s%s",
| ^~
458 | (int)address, *tmp ? "." : "", tmp);
| ~~~
D:/a/libserialport/libserialport/windows.c:457:41: note: 'snprintf' output between 2 and 44 bytes into a destination of size 32
457 | snprintf(usb_path, sizeof(usb_path), "%d%s%s",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
458 | (int)address, *tmp ? "." : "", tmp);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1.exe: all warnings being treated as errors
make[2]: *** [CMakeFiles/libserialport.dir/build.make:76: CMakeFiles/libserialport.dir/windows.c.obj] Error 1
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/libserialport.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
```
.gitattributes file might already work
ndim
force-pushed
the
add-version-suffix
branch
from
6b4f513 to
34a8286
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR to save the work, more description to follow.