Wait Util CI Failure

[harvey0100]

Amended the buffer time for test to allow CI to pass.

Summary by CodeRabbit

• Tests
  • Relaxed timing tolerances and broadened assertion ranges for time-sensitive tests to better accommodate CI variability, improving test reliability and reducing flaky failures.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Two timing-related assertions in selftests/unit/utils/wait.py were relaxed: test_timeout_returns_none increased its maximum allowed elapsed time from 0.7s to 1.5s; test_step_interval increased its timeout argument from 0.5s to 1.0s and broadened the expected call_count range (now 4–10) with an updated comment reflecting expected attempts. No functional logic or public API signatures were changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Changes confined to one test file: selftests/unit/utils/wait.py
• Simple numeric adjustments and a comment update; no logic or control-flow modifications
• Quick checks:
  • Confirm the new tolerances (1.5s timeout, 1.0s step timeout, call_count range 4–10) are appropriate for CI variability
  • Ensure assertions still meaningfully verify behavior and won't mask regressions

Pre-merge checks

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Wait Util CI Failure' is vague and does not clearly describe the actual changes, which involve relaxing timeout assertions in wait utility tests to accommodate CI variance.	Consider a more descriptive title like 'Increase timeout tolerances in wait utility tests for CI stability' that clearly conveys the nature of the changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1580e7e and 7e8422b.

📒 Files selected for processing (1)

• selftests/unit/utils/wait.py (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• selftests/unit/utils/wait.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: Version task ubi:9.2
• GitHub Check: Version task ubi:8.8
• GitHub Check: Version task fedora:40
• GitHub Check: Fedora develop install/uninstall task
• GitHub Check: Fedora selftests
• GitHub Check: Version task ubuntu:22.04
• GitHub Check: Version task debian:12.4
• GitHub Check: Build Package (wheel/tarball) for Python 3.10
• GitHub Check: macOS with Python 3.11
• GitHub Check: Static checks
• GitHub Check: Code Coverage (3.11)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.48%. Comparing base (74b7379) to head (7e8422b).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6250   +/-   ##
=======================================
  Coverage   73.48%   73.48%           
=======================================
  Files         206      206           
  Lines       22494    22494           
=======================================
  Hits        16530    16530           
  Misses       5964     5964           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.