-
Notifications
You must be signed in to change notification settings - Fork 364
fix: add kernel build directory config path to check_kernel_config #6244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new kernel config file location ( Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (45)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello @richtja, this is a fix for kernel build from source code, please help to review, thanks. ls /lib/modules/$(uname -r)/build/.config
/lib/modules/6.11.0+/build/.config |
4efe80a to
9d30e3e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6244 +/- ##
=======================================
Coverage 73.50% 73.50%
=======================================
Files 206 206
Lines 22497 22497
=======================================
Hits 16536 16536
Misses 5961 5961 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@PaulYuuu can you please rebase this so that it picks up the CI fixes? Thanks! |
Add /lib/modules/{kernel_version}/build/.config as a configuration
location to search for kernel config files. This is a common location
where the kernel configuration is stored in the build directory.
Signed-off-by: Yihuang Yu <[email protected]>
9d30e3e to
3bfce6b
Compare
Hello @clebergnu, sure, I have updated. But still 2 failures not related to this PR.
The runner catch all exception into error avocado/avocado/plugins/runners/avocado_instrumented.py Lines 129 to 138 in 4ff9e2c
TestInterrupt, I assume we should handle it gracefully like
except TestInterrupt as e:
queue.put(
messages.FinishedMessage.get(
"interrupted",
fail_reason=str(e),
)
)
except Exception as e:This is another topic, I also meet some failure in the pyproject migration, we should fix them 1 by 1. |
richtja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PaulYuuu, it LGTM. Thank you
Add /lib/modules/{kernel_version}/build/.config as a configuration location to search for kernel config files. This is a common location where the kernel configuration is stored in the build directory.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.