dd command to read certain number of blocks #6240
Closed
+3,016
−399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: avocado-framework#6183 Signed-off-by: Jan Richter <[email protected]>
The utility deprecation warning on `aurl` utility is causing troubles, because it's logged every time the utility is used, which pollutes test logs. This commit will log the warning only once and also makes the solution more general for future use during the AAutils migration. Assisted-by: Cursor with gemini-2.5-pro Reference: avocado-framework#6176 Signed-off-by: Jan Richter <[email protected]>
since the path development has been migrated to AAutils we need to inform users and developers about this change. Reference: avocado-framework/aautils#84 Signed-off-by: Jan Richter <[email protected]>
Improve VMImage caching and asset handling functionality. - Enhanced asset.py to handle direct file paths and normal asset names - Better error handling and logging in get_metadata() - Refactored _find_cached_image() to use Asset functionality - Fixed multiple Pylint warnings (too-many-branches, protected-access, etc.) - Improved network error handling in provider selection Assisted By: Cursor GPT-5 Signed-off-by: Harvey Lynden <[email protected]>
Update Fedora provider to use archive URLs for versions <= 40 instead of <= 38 to fix download failures for Fedora 39/40. Assisted By: Cursor GPT-5 Signed-off-by: Harvey Lynden <[email protected]>
Announcement of deprecation of data_structures. Signed-off-by: Harvey Lynden <[email protected]>
Without this change, running the gdb example tests (examples/tests/gdbtest.py) will fail on newer gcc. Signed-off-by: Cleber Rosa <[email protected]>
These module level variables were used to control the behavior of the gdb utility from the command line plugin. The plugin was never migrated to nrunner due to the parallelism aspects, so these are not needed anymore. Signed-off-by: Cleber Rosa <[email protected]>
This is a set of docstrings updates to prepare this utility for migration to AAutils project. Reference: avocado-framework/aautils#82 Assisted-by: Cursor Claude 4 Sonnet Signed-off-by: Cleber Rosa <[email protected]>
For the distro version 8 and older releases distro version less than 9 check is sufficient Signed-off-by: Pavaman Subramaniyam <[email protected]>
There's a clear mistake in the assigment made, which overwrites an unintended variable. This is because of the variable rename from upper to lower case in commit 57dcecf. Signed-off-by: Cleber Rosa <[email protected]>
The GDB example tests all depend on gcc because of the shared setUp() method. Then, some will use only the GDB class (and thus depend on the "gdb" binary), while others will use both GDB and GDBServer classes (and thus also depend on the "gdbserver" binary). This fortifies the execution of these tests in environments without those external software packages installed. Signed-off-by: Cleber Rosa <[email protected]>
There's a functional GDB test that is being shipped only as an example test. We can make it run during the selftests to increase the module coverage (and avoid regression as could be observed in the last few commits). Signed-off-by: Cleber Rosa <[email protected]>
Migration of External Util Pylint Reference: avocado-framework/aautils#38 Signed-off-by: Harvey Lynden <[email protected]>
This is a docstring update for network utility as preparation for AAutils migration. Assisted-by: Cursor with gemini-2.5-pro Reference: avocado-framework/aautils#76 Signed-off-by: Jan Richter <[email protected]>
This is a set of unit tests updates and checks to prepare avocado.utils.network utility for migration to AAutils project. Assisted-by: Cursor with gemini-2.5-pro Reference: avocado-framework/aautils#76 Signed-off-by: Jan Richter <[email protected]>
The check for packet loss wasn't considering losses of full numbers like 10, 20, ..., 100. All of them would be considered as 0%. This commit fixes it. Assisted-by: Cursor with gemini-2.5-pro Signed-off-by: Jan Richter <[email protected]>
When the device doesn't have any ip address the nm_flush_ipadd method would still run `ip addr delete`. This commit avoids it. Assisted-by: Cursor with gemini-2.5-pro Signed-off-by: Jan Richter <[email protected]>
Since the network.ports development has been migrated to AAutils we need to inform users and developers about this change. Reference: avocado-framework/aautils#88 Signed-off-by: Jan Richter <[email protected]>
Warning of development moving over to AAutils for External Modules. Reference: avocado-framework/aautils#69 Signed-off-by: Harvey Lynden <[email protected]>
This fixes a number of issues with a pre-release check for the latest
avocado build:
1. The repo with the actual latest build is called
"avocado-latest" (while the latest released build
is called "avocado-latest-release")
2. Fedora 40 has been EOL'd and it's been bumped to 42
The new container images with these changes are already deployed on
quay.io.
Signed-off-by: Cleber Rosa <[email protected]>
The LEAP 15.2 version has been EOL'd and removed from the website. The other versions suffered a few naming adjustments, which this covers. Signed-off-by: Cleber Rosa <[email protected]>
Increase Code Coverage - Added RST Docstrings Reference: avocado-framework/aautils#42 Assisted-By: Claude 4 Sonnet Cursor Signed-off-by: Harvey Lynden <[email protected]>
On Python 3.9 and earlier, we're pinning the cffi dep. With the most recent cryptography release (46.0.0), a more recent cffi version is required. This causes the dependency resolution to be impossible. Let's also pin the version of cryptography on Python 3.9, along with cffi. Signed-off-by: Cleber Rosa <[email protected]>
Assisted-by: Cursor with cloude-4-sonnet Signed-off-by: Jan Richter <[email protected]>
Signed-off-by: Jan Richter <[email protected]>
We've seen headers and messages that make it difficult to review pull requests or understand recent changes. Explain the purpose of both a bit more and provide an example to help contributors understand better what is expected and serve as reference. Signed-off-by: Sebastian Mitterle <[email protected]>
The TaskRunStatusService.test_task_status_service_lost, from selftests/functional/nrunner.py, fails every now and then. There are a number of expectations with regards to the timing of both the netcat process and listening socket, and the avocado-runner process. The following changes are added here in an effort to mitigate or eliminate those failures: * A wait was added after the netcat process starts, and before the avocado-runner process is created and started, improving the odds that the netcat socket will be available. * A longer execution time for the underlying executable (/bin/sleep) mitigates the possibility of it ending before netcat is killed. * A longer sleep after the avocado-runner process is started improves the odds of it having properly started and connected to the socket. * Waiting for the end of the netcat process makes sure the assertion is not tried without the connection having being broken on the netcat side. Signed-off-by: Cleber Rosa <[email protected]>
Announcement of deprecation of Output Signed-off-by: Harvey Lynden <[email protected]>
- Add comprehensive docstrings with parameter types, return values, and examples - Include detailed descriptions for all functions - Add proper Sphinx documentation formatting - Remove redundant '(0s and 1s)' descriptions from bitlist functions - Simplify iter_tabular_output docstring to original concise version - Update spell.ignore for new documentation terms Reference: avocado-framework/aautils#48 Assisted-By: Claude 4 Sonnet Cursor Signed-off-by: Harvey Lynden <[email protected]>
- Add full test coverage for bitlist_to_string and string_to_bitlist functions - Add tests for shell_escape function with various special characters - Add tests for strip_console_codes with ANSI escape sequences - Add tests for tabular output functions (iter_tabular_output, tabular_output) - Add tests for string utility functions (string_safe_encode, string_to_safe_path) - Add tests for type checking functions (is_bytes, is_text, to_text) - Update check.py to include astring module in testing - Condense multi-line bitlist definitions into readable one-liners Reference: avocado-framework/aautils#48 Assisted-By: Claude 4 Sonnet Cursor Signed-off-by: Harvey Lynden <[email protected]>
Normalize hex escape sequences to lowercase for consistency with Python coding conventions. While both forms are functionally identical, lowercase hex digits align with community standards and prevent potential linting inconsistencies across different tools. Signed-off-by: Harvey Lynden <[email protected]>
FreeBSD reserves /etc for the base system configuration. All other software should usr /usr/local/etc instead. Reference: https://man.freebsd.org/cgi/man.cgi?hier(7) Reported-by: Roman Bogorodskiy <[email protected]> Signed-off-by: Cleber Rosa <[email protected]>
This definition is required for Scenarios which require reading certaing number of block from disk Current usage is with nvme SED operation, But it comman across all block devices Signed-off-by: Maram Srimannarayana Murthy <[email protected]>
|
You are changing one of the avocado utils which has already been migrated to AAutils project https://github.com/avocado-framework/aautils and this utility will be removed after the LTS release. Please make sure that all your proposed changes are already in AAutils and this PR is only backport. For more information about AAutlis migration see https://avocado-framework.readthedocs.io/en/latest/blueprints/BP005.html For a list of migrated utilities see https://avocado-framework.github.io/aautils.html |
|
Caution Review failedThe pull request is closed. WalkthroughThis PR implements Avocado version 112.0 with a broad set of improvements and maintenance updates. Key changes include introducing platform-specific path handling for FreeBSD, establishing a centralized deprecation warning system across multiple utility modules, adding system-level build dependencies for GDB and compiler tooling, expanding docstrings and type annotations throughout the codebase, implementing cached VM image lookup functionality, fixing a state-keying bug in the Spark parser, removing deprecated GDB module constants, and extending test coverage for network utilities. Version identifiers are incremented from 111.0 to 112.0 across the main package and all optional plugins. Release documentation for 112.0 is added alongside updates to development branches. Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (54)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Looks like wrong request. WIll create new request. |
github-project-automation
bot
moved this from Review Requested
to Done 113
in Default project
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6240 +/- ##
==========================================
+ Coverage 68.53% 74.78% +6.25%
==========================================
Files 205 206 +1
Lines 22412 22497 +85
==========================================
+ Hits 15359 16825 +1466
+ Misses 7053 5672 -1381 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition help to read required number of block from a block device. Which is command across all devices
Summary by CodeRabbit
New Features
Improvements
Platform Support
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.