python-avocado.spec: update format of license to match SPDX #6232
Conversation
WalkthroughSpec file updates for python-avocado: Release bumped from Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (46)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
python-avocado.spec (1)
273-273: Incomplete SPDX license conversion - all subpackages need updating.The main package License field was updated to SPDX format, but all 13 subpackage License fields remain in the old format. For consistency and to fully comply with SPDX standards, all License fields should be converted.
Required conversions:
GPLv2+→GPL-2.0-or-laterGPLv2→GPL-2.0-onlyand→ANDAffected subpackages:
- Line 273: python3-avocado-common
- Line 300: python3-avocado-plugins-output-html
- Line 317: python3-avocado-plugins-resultsdb
- Line 333: python3-avocado-plugins-varianter-yaml-to-mux
- Line 347: python3-avocado-plugins-golang
- Line 363: python3-avocado-plugins-ansible
- Line 379: python3-avocado-plugins-varianter-pict
- Line 392: python3-avocado-plugins-varianter-cit
- Line 406: python3-avocado-plugins-result-upload
- Line 419: python3-avocado-plugins-result-mail
- Line 433: python3-avocado-plugins-spawner-remote
- Line 446: python3-avocado-examples
- Line 466: python3-avocado-bash
Apply this diff to complete the SPDX conversion:
%package -n python3-avocado-common Summary: Avocado common files -License: GPLv2+ +License: GPL-2.0-or-later %package -n python3-avocado-plugins-output-html Summary: Avocado HTML report plugin -License: GPLv2+ and MIT +License: GPL-2.0-or-later AND MIT %package -n python3-avocado-plugins-resultsdb Summary: Avocado plugin to propagate job results to ResultsDB -License: GPLv2+ +License: GPL-2.0-or-later %package -n python3-avocado-plugins-varianter-yaml-to-mux Summary: Avocado plugin to generate variants out of yaml files -License: GPLv2+ +License: GPL-2.0-or-later %package -n python3-avocado-plugins-golang Summary: Avocado Plugin for Execution of golang tests -License: GPLv2+ +License: GPL-2.0-or-later %package -n python3-avocado-plugins-ansible Summary: Avocado Ansible Dependency plugin -License: GPLv2+ +License: GPL-2.0-or-later %package -n python3-avocado-plugins-varianter-pict Summary: Varianter with combinatorial capabilities by PICT -License: GPLv2+ +License: GPL-2.0-or-later %package -n python3-avocado-plugins-varianter-cit Summary: Varianter with Combinatorial Independent Testing capabilities -License: GPLv2+ +License: GPL-2.0-or-later %package -n python3-avocado-plugins-result-upload Summary: Avocado Plugin to propagate Job results to a remote host -License: GPLv2+ +License: GPL-2.0-or-later %package -n python3-avocado-plugins-result-mail Summary: Avocado Mail Notification for Jobs -License: GPLv2+ +License: GPL-2.0-or-later %package -n python3-avocado-plugins-spawner-remote Summary: Avocado Plugin to spawn tests on a remote host -License: GPLv2+ +License: GPL-2.0-or-later %package -n python3-avocado-examples Summary: Avocado Test Framework Example Tests -License: GPLv2+ +License: GPL-2.0-or-later %package -n python3-avocado-bash Summary: Avocado Test Framework Bash Utilities -License: GPLv2+ and GPLv2 +License: GPL-2.0-or-later AND GPL-2.0-onlyAlso applies to: 300-300, 317-317, 333-333, 347-347, 363-363, 379-379, 392-392, 406-406, 419-419, 433-433, 446-446, 466-466
🧹 Nitpick comments (1)
python-avocado.spec (1)
478-480: Update changelog to reflect all changes.The changelog entry correctly documents the SPDX license format update, but doesn't mention the Source0 addition on line 37. If that change is intentionally included in this PR, it should be noted in the changelog.
Consider adding to the changelog:
* Fri Nov 07 2025 Cleber Rosa <[email protected]> - 112.0-2 - Update format of license to match The System Package Data Exchange (SPDX) +- Add Source0 for snapshot builds
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
python-avocado.spec(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
- GitHub Check: rpm-build:fedora-43-x86_64
- GitHub Check: rpm-build:fedora-41-s390x
- GitHub Check: rpm-build:centos-stream-9-x86_64
- GitHub Check: rpm-build:epel-9-x86_64
- GitHub Check: rpm-build:fedora-41-x86_64
- GitHub Check: Linux with Python 3.9
- GitHub Check: Linux with Python 3.10
- GitHub Check: Linux with Python 3.12
- GitHub Check: Linux with Python 3.13
- GitHub Check: Linux with Python 3.11
- GitHub Check: Fedora selftests
- GitHub Check: Egg task ubuntu:22.04
- GitHub Check: Podman spawner with 3rd party runner plugin
- GitHub Check: Version task debian:12.4
- GitHub Check: Egg task ubi:8.8
- GitHub Check: Version task ubi:8.8
- GitHub Check: Version task ubuntu:22.04
- GitHub Check: Version task ubuntu:24.04
- GitHub Check: macOS with Python 3.11
- GitHub Check: Static checks
- GitHub Check: Code Coverage (3.11)
🔇 Additional comments (3)
python-avocado.spec (3)
31-31: LGTM!Correctly incremented the release number for spec file modifications.
32-32: SPDX license conversion is correct.The main package License field has been properly converted to SPDX format following the standards at https://spdx.org/licenses/.
34-38: Source0 addition is correct but unrelated to license update.The Source0 line for the snapshot build path (line 37) properly mirrors the release build structure. However, this change appears unrelated to the PR's stated objective of updating the license format to SPDX.
Consider whether this Source0 fix should be in a separate commit or PR for clarity, or ensure it's mentioned in the changelog entry.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6232 +/- ##
==========================================
+ Coverage 73.56% 73.58% +0.01%
==========================================
Files 206 206
Lines 22497 22497
==========================================
+ Hits 16550 16554 +4
+ Misses 5947 5943 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'll wait for the review/merge of https://src.fedoraproject.org/rpms/python-avocado/pull-request/51 and then proceed with an upstream version. |
clebergnu
force-pushed
the
rpm_license
branch
from
b5193fd to
80a644a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
python-avocado.spec(15 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (46)
- GitHub Check: rpm-build:fedora-41-s390x
- GitHub Check: rpm-build:fedora-41-ppc64le
- GitHub Check: rpm-build:fedora-rawhide-x86_64
- GitHub Check: rpm-build:centos-stream-9-x86_64
- GitHub Check: rpm-build:fedora-41-aarch64
- GitHub Check: rpm-build:epel-9-x86_64
- GitHub Check: rpm-build:fedora-43-x86_64
- GitHub Check: rpm-build:fedora-42-x86_64
- GitHub Check: rpm-build:fedora-rawhide-x86_64
- GitHub Check: rpm-build:fedora-42-x86_64
- GitHub Check: rpm-build:fedora-41-ppc64le
- GitHub Check: rpm-build:fedora-41-x86_64
- GitHub Check: rpm-build:epel-9-x86_64
- GitHub Check: rpm-build:fedora-41-aarch64
- GitHub Check: rpm-build:fedora-43-x86_64
- GitHub Check: rpm-build:centos-stream-9-x86_64
- GitHub Check: rpm-build:fedora-41-s390x
- GitHub Check: Linux with Python 3.10
- GitHub Check: Linux with Python 3.11
- GitHub Check: Linux with Python 3.13
- GitHub Check: Linux with Python 3.12
- GitHub Check: Linux with Python 3.9
- GitHub Check: rpm-build:fedora-41-aarch64
- GitHub Check: rpm-build:fedora-42-x86_64
- GitHub Check: rpm-build:fedora-41-x86_64
- GitHub Check: rpm-build:fedora-43-x86_64
- GitHub Check: rpm-build:fedora-rawhide-x86_64
- GitHub Check: rpm-build:fedora-41-ppc64le
- GitHub Check: rpm-build:fedora-41-s390x
- GitHub Check: rpm-build:centos-stream-9-x86_64
- GitHub Check: rpm-build:epel-9-x86_64
- GitHub Check: rpm-build:centos-stream-9-x86_64
- GitHub Check: rpm-build:fedora-41-x86_64
- GitHub Check: rpm-build:fedora-rawhide-x86_64
- GitHub Check: rpm-build:fedora-42-x86_64
- GitHub Check: rpm-build:fedora-43-x86_64
- GitHub Check: rpm-build:epel-9-x86_64
- GitHub Check: rpm-build:fedora-41-ppc64le
- GitHub Check: rpm-build:fedora-41-s390x
- GitHub Check: rpm-build:fedora-41-aarch64
- GitHub Check: Fedora selftests
- GitHub Check: Version task ubuntu:22.04
- GitHub Check: Version task ubi:8.8
- GitHub Check: Version task debian:12.4
- GitHub Check: macOS with Python 3.11
- GitHub Check: Code Coverage (3.11)
🔇 Additional comments (2)
python-avocado.spec (2)
31-32: SPDX license conversions look consistent across packages (except bash subpkg).The updated
License:tags use valid SPDX IDs (GPL-2.0-or-later,GPL-2.0-only,MIT) and the compound expressions match the previousGPLv2+/GPLv2/MITsemantics for the main and plugin packages. No issues spotted here aside from the bash subpackage handled separately below.Also applies to: 273-273, 300-300, 317-317, 333-333, 347-347, 363-363, 379-379, 392-392, 406-406, 419-419, 433-433, 447-447
31-31: Release bump aligned with changelog entry.
Release: 2%{?gitrel}%{?dist}matches the new changelog entry112.0-2, with the date and NVR consistent; this looks correct.Also applies to: 478-480
This was suggested in a Fedora package interaction. Reference: https://spdx.org/licenses/ Signed-off-by: Cleber Rosa <[email protected]>
clebergnu
force-pushed
the
rpm_license
branch
from
80a644a to
bad0301
Compare
github-project-automation
bot
moved this from Review Requested
to Done 113
in Default project
2 participants
This was suggested in a Fedora package interaction.
Reference: https://spdx.org/licenses/
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.