Removed unused code in elm-format-lib #812
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avh4
reviewed
Apr 1, 2023
| -- in | ||
| -- do touchForeignPtr fptr | ||
| -- return result | ||
|
|
There was a problem hiding this comment.
This will eventually be needed; ideally https://github.com/avh4/elm-format/blob/main/elm-format-lib/src/ElmFormat/Parse.hs#L22 will change to take ByteString instead of Text, and https://github.com/avh4/elm-format/blob/aded67fb5db42afd17bfa372eab23f8a01cb635d/elm-format-lib/src/Parse/Parse.hs will change to take ByteString instead of String.
Sorry things are a bit of a mess atm.
There was a problem hiding this comment.
Specifically, #301 is the blocking issue for the above mentioned ideal changes.
| @@ -58,11 +57,6 @@ instance Coapplicative Located where | |||
| {-# INLINE extract #-} | |||
|
|
|||
|
|
|||
| traverse :: (Functor f) => (a -> f b) -> Located a -> f (Located b) | |||
| traverse func (At region value) = | |||
| At region <$> func value | |||
There was a problem hiding this comment.
I'm a little hesitant to remove, as it might be useful for some upcoming features. Though maybe this should be moved to a Traversable instance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some unused code.