-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds twitter widget #23
Conversation
I'm not opposed to it, generally the Twitter widgets look pretty awful but the colors are close to the site here and it does provide a good overview of people currently talking about #pairwithme A couple of changes you'll want to make though:
It's @avdi's call but my opinion would be that with the above changes it'll be a decent addition to the site. |
I agree with @chrisradford. I was also thinking about moving the widget down into the sidebar of the "resources" section rather than in the top section. |
@avdi I considered if it shouldn't go into the resources section, but I found it more advantageous to have the tweets "above the fold". Thank you both for the feedback, I'll implement the suggestions in the next couple days. |
Looking forward to it! |
@locks any more on this? Thanks. |
I like this idea. Can it have a title like 'Who's pairing?' This might be a good use case to move in some the https://github.com/rubyrogues/rubyfriends/blob/master/lib/twitter_search.rb twitter search code (which I'd like to make into an engine), so that it pulls the tweets from a db and gives us more control over how we surface it and performance and then if we have users sharing their twitters handles and logging in.. could be pretty cool.. rubyrogues/ppwm-matcher#47 |
@bf4 does that code work with the V1.1 API? Also, would having the feed read from the Database not remove much of the value of seeing a realtime list of "Who's Pairing?"… |
@chrisradford it works with the latest api, see the twitter gem it uses. as for realtime.. sure, I suppose, or we use the streaming api or be satisfied with an update as frequent as we update the tweets. This would be a step 2 anyway as, unless you're going to copy and paste, the twitter stuff in rubyfriends isn't fully abstracted into an engine, yet. |
my bad on the radio silence, I've been a tad busy with exams/work. |
@locks it could, sure, in the sense that we would build the widget with data from the db rather than the twitter js api. |
Hey, just saw this, kind of interesting: yui3 tweets though there might actually be a newer version of the repo somewhere |
Should we move forward on this PR or close it? |
sorry @bf4. as you can see from my profile, I still haven't quite gotten back on the proverbial horse. thanks for the patience. |
@locks No need to discuss horses; I don't think there was any resolution of the desired implementation. |
I'm in favour of the option without the twitter embed widget, since it's not particularly pretty or customisable (and I believe linked to a single username). @locks if you're still up for building this out it would be nice addition, I'd personally use the twitter gem but go for whatever works for you. Regarding location on the page; that can change, go for whichever and we can move it later if needed. @bf4 anything I've missed? And yes, it'd be good to get this closed off. |
Hi,
I just had an idea and thought I'd cook up a small PR to open up the discussion, instead of just opening an Issue.
I think it would be added value to have a small Twitter widget that shows #pairwithme tweets, so you can instantly see if anyone's available at the moment.
Never mind the style mangling, just want to gauge interest :)
Here's a screenshot of my change: