Version warning when local version is behind

[timdeschryver]

Fixes #1336

Added variable process.env.AVA_LOCAL_CLI to show the correct message.

[novemberborn]

Thanks for opening the PR @tdeschryver. There's some subtle logic issues. Might be worth stubbing the update-notifier module in lib/cli.js to verify the isGlobal value.

We've been having some trouble with the CI so I don't think those failures are due to this PR.

[novemberborn]

This bit (localCLI && path.relative(localCLI, __filename) !== '') needs to be cast to a string: String(localCLI && path.relative(localCLI, __filename) !== ''). Otherwise the comparison on the next line won't be true.

[timdeschryver]

Oh I didn't know that. When I was debugging it, it was a automatically converted to a string.
Its changed now.

[novemberborn]

Shouldn't this be !== 'true'?

[timdeschryver]

Yep, you're right. My bad!

[timdeschryver]

@novemberborn I was trying to figure out how I could test the isGlobal value and to be honest I'm kinda stuck. The only way to test it would be to call lib/cli directly and stub almost everything (update-notifier, pkg-conf, api, ...), and put a test inside the .notify() function?

[novemberborn]

@tdeschryver in your current test, try this:

const notifySpy = sinon.spy()

proxyquire('../cli', {
  debug: debugStub,
  'resolve-cwd': resolveCwdStub,
  './lib/cli': proxyquire('../lib/cli', {
    'update-notifier' () {
      return {notify: notifySpy}
    }
  })
});

You should then be able to assert on the notifySpy arguments.

[timdeschryver]

@novemberborn I don't think that will work (or I am missing something), the problem is we are stubbing resolveCwd with /fixture/empty, thus the lib/cli is never being called. I tried creating a new test where lib/cli is being called, the problem here is that it will test some files and to ignore this we'll have to stub a lot of things I think.

EDIT: just tried this and the notify function isn't being called as far as I can see.

[novemberborn]

@tdeschryver could you push your attempt? I'll try on my end.

[timdeschryver]

@novemberborn I discarded my changes, would it help you if I rewrite it?

[novemberborn]

@tdeschryver yea I'll try and give this a go. #1376 landing also threw a wrench into the works.

[novemberborn]

@sindresorhus import-local breaks the approach taken in this PR. We need to set AVA_LOCAL_CLI before the local CLI module is required. import-local requires the module immediately. Perhaps it could export an existsSync method?

[sindresorhus]

I think we're trying to solve this problem in the wrong place. Better to fix it in update-notifier so it's fixed for everyone. See: yeoman/update-notifier#112

[timdeschryver]

@sindresorhus is it OK if I'm going to take a look at it?

[sindresorhus]

@tdeschryver Go ahead 😃

[timdeschryver]

Bumped update-notifier since yeoman/update-notifier#114 is merged.

[sindresorhus]

Thanks @tdeschryver :)