feat: add acp224 precompile #4866
Open
+2,352
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanOppenheimer
added
the
acp224
JonathanOppenheimer
added
evm
Co-authored-by: Michael Kaplan <[email protected]>
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/add-acp224-precompile
branch
from
657c3cd to
7b9bb3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds the ACP-224 Fee Manager precompile to enable dynamic gas limit configuration in subnet-evm. This implements the configuration interface specified in https://build.avax.network/docs/acps/224-dynamic-gas-limit-in-subnet-evm.
Note that this PR only the precompile package for reading/writing configuration state. The core blockchain integration (using these values for actual gas limit adjustments) is deferred to after SAE, as SAE will redo the ACP-176 mechanism.
How this works
The precompile provides three functions with AllowList-based access control:
setFeeConfig(FeeConfig)- Updates configuration (Admin/Manager/Enabled only)getFeeConfig()- Retrieves current configuration (public)getFeeConfigLastChangedAt()- Returns block number of last update (public)How this was tested
Need to be documented in RELEASES.md?
Yes, but probably not in this PR, as this doesn't change anything. Once the precompile is fully available and functional, the release notes should be updated.