Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated workflows for latest 1Password, added architecture selection #225

Closed
wants to merge 4 commits into from
Closed

Conversation

mpanighetti
Copy link
Contributor

  • updated to current 1Password URL 1Password recipes still pulling down v7 when v8 is out (though v7 updates are still coming) #222
  • added support for Intel/Apple Silicon download selection via %PLATFORM_ARCH% input variable (defaults to Intel)
  • replaced .pkg unpacker steps with Unarchiver (app is now distributed in a zip)
  • updated code signature requirement for current app version
  • updated packaging workflow to account for changes in download recipe
  • added platform architecture to .pkg file name
  • linted files

- updated to current 1Password URL
- added support for Intel/Apple Silicon download selection via `%PLATFORM_ARCH%` input variable (defaults to Intel)
- replaced pkg unpacker steps with Unarchiver (app is now distributed in a zip)
- updated code signature requirement for current app version
- linted file
- updated packaging workflow to account for changes in download recipe (different app name, upzipped .app vs already packaged, different path variables)
- linted file
- added platform architecture to file name
- typo correction (bad copy-paste from another recipe)
@mpanighetti
Copy link
Contributor Author

#222 mentions that there might be some value in maintaining a 1Password 7 stack of recipes, so those could be cloned from the previous versions of these recipes and given unique identifiers. Happy to do so in this PR if desired.

@mpanighetti
Copy link
Contributor Author

The suggested changes in this PR were implemented in nstrauss-recipes. Leaving this in place as a 1Password 7-specific recipe.

@mpanighetti mpanighetti closed this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant