TeamViewer Installs/Optional Receipts fix #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update master
…e munki repos. add pkginfo merge so that installs array is not lost.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current munki recipe utilizes the MunkiPkginfoReceiptsEditor processor. This processor functions by making changes to the pkginfo flat file. When using a munki repo that is not flat-file based, the processor fails because it cannot open and modify the pkginfo. As a result, the recipe fails to add the optional keys to the receipts array if the munki repository is not a local or mounted folder.
Interestingly enough, the
TeamViewer.pkg.recipeimplements theMunkiInstallsItemsCreatoras noted by @hansen-m in #173. This information is lost (not committed to the final pkginfo), however, as there is no necessaryMunkiPkginfoMergerprocessor included after.This MR removes the troublesome optional receipts approach and adds
MunkiPkginfoMergerso that the installs approach may be used.