Support web builds #137
Merged
Support web builds #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update caller info to include function and module separately * Update tests * Fix import order linter issue * Update biome.json * Update packages/autometrics/src/wrappers.ts Co-authored-by: Arend van Beelen jr. <[email protected]> * Update otlp exporter snapshot test * fix example tests --------- Co-authored-by: Arend van Beelen jr. <[email protected]>
arendjr
commented
Oct 31, 2023
| @@ -0,0 +1,3 @@ | |||
| const fetch = global.fetch; | |||
|
|
|||
| export { fetch }; | |||
There was a problem hiding this comment.
Added this to a separate file so that we can easily replace the file with node-fetch-native when building the Node bundles.
This was
linked to
issues
Nov 6, 2023
Closed
keturiosakys
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, this was a bit more involved again than I'd hoped. But! We have first-class web builds now... at least in the NPM packages. What this PR does:
dntwithrollup. Whiledntwas a great starting point, and is certainly easier out-of-the-box, we didn't really use their shimming abilities anyway androllupgives us the flexibility to more easily build dedicated web builds. Also, the packages are now smaller, since everything gets bundled into single-file builds.$otel/*imports. This makes it a lot easier to upgrade the OpenTelemetry libs, since the version numbers aren't hardcoded all over the place anymore.AsyncLocalStorage.react-app-experimentalis now also included in the builds and type-checking.just cleanis a bit more thorough, by also removingnode_modulesand.yarnwhere applicable.Resolves #89, #100, #133 and #134.