Skip to content

fix(profile-cache): resolve race condition on fresh install #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
filipexyz wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(profile-cache): resolve race condition on fresh install #283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
286cdc5
fix(profile-cache): resolve race condition on fresh install
filipexyz Nov 28, 2025
942b6ba
refactor(router): use idiomatic Result<Option> pattern
filipexyz Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion forge-app/src/router.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ use uuid::Uuid;
use crate::services::ForgeServices;
use db::models::{
image::TaskImage,
project::Project,
task::{Task, TaskWithAttemptStatus},
task_attempt::{CreateTaskAttempt, TaskAttempt},
};
Expand Down Expand Up @@ -1763,6 +1764,25 @@ async fn get_project_profiles(
Path(project_id): Path<Uuid>,
State(services): State<ForgeServices>,
) -> Result<Json<ApiResponse<executors::profile::ExecutorConfigs>>, StatusCode> {
// Fetch project from database to ensure it exists and get workspace path
let project = Project::find_by_id(&services.pool, project_id)
.await
.map_err(|e| {
tracing::error!("Database error fetching project {}: {}", project_id, e);
StatusCode::INTERNAL_SERVER_ERROR
})?
.ok_or_else(|| {
tracing::error!("Project {} not found", project_id);
StatusCode::NOT_FOUND
})?;

// Ensure project is registered in profile cache (fixes race condition on fresh installs)
services
.profile_cache
.register_project(project.id, project.git_repo_path.clone())
.await;

// Now safe to lookup profiles
services
.profile_cache
.get_profiles_for_project(project_id)
Expand All @@ -1777,7 +1797,7 @@ async fn get_project_profiles(
})
.map_err(|e| {
tracing::error!("Failed to load profiles for project {}: {}", project_id, e);
StatusCode::NOT_FOUND
StatusCode::INTERNAL_SERVER_ERROR
})
}

Expand Down
Loading