Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary deps #199

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Remove unnecessary deps #199

merged 2 commits into from
Sep 9, 2024

Conversation

tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Sep 9, 2024

Description

This is something I noticed when I was working on a related issue. We've got two dependencies that don't show up in exported code and we've got a dependency listed as a dep that should be a dev dep. This fixes that and reduces our install surface.

Changes

  • Remove the google-api packages that aren't referenced
  • Add a better dep for the referenced proto classes that the old deps were supposed to satisfy
  • Move the typing_extensions lib to a dev dep

Testing

See that things still go green

@tstirrat15 tstirrat15 requested a review from a team as a code owner September 9, 2024 21:37
@tstirrat15 tstirrat15 added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit f3ea1ad Sep 9, 2024
15 checks passed
@tstirrat15 tstirrat15 deleted the remove-unnecessary-deps branch September 9, 2024 22:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants