Avoid portal dependencies from reference external CDN #4931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louischan-oursky
force-pushed
the
dev-2357-self-host-portal-dependency-assets
branch
3 times, most recently
from
04f1463 to
1f72bbf
Compare
The weird thing is, this pattern occurs in other place as well. But only this place is corrected.
louischan-oursky
force-pushed
the
dev-2357-self-host-portal-dependency-assets
branch
from
1f72bbf to
a5fbefe
Compare
tung2744
reviewed
Dec 11, 2024
Contributor
There was a problem hiding this comment.
Do we need to commit the files in shared-assets? 🤔
Or they should be generated after npm install?
Contributor
Author
There was a problem hiding this comment.
The postinstall script was intended to automate the update of these files, not for generating the files after npm install. Having the public directory contain we will serve with a simple git checkout is easier to understand.
Contributor
There was a problem hiding this comment.
I see. But I am worried about the repo size :sosad:
tung2744
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DEV-2357