feat: initial tvOS support #959
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbrentkelly
had a problem deploying
to
external
GitHub Actions
Failure
mrbrentkelly
had a problem deploying
to
external
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Auth0.swift library supports tvOS, but when trying to link
react-native-auth0to a tvOS project, there are compilation issues in its native swift bridging code due to accessing APIs that aren't available on tvOS (e.g.Auth0.webAuth,WebAuthenticationetc).This PR add
tvosas a supported platform in thereact-native-auth0podspec and wraps applicable pieces of the native swift bridging code in#if os(tvOS) .. #else .. ##endifstatements.This allows the
react-native-auth0lib to be compiled for tvOS whilst not changing the iOS side at all.References
Testing
This change adds unit test coverageChecklist