Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back dependabot config for npm #724

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Sep 18, 2023

Changes

Adds back dependabot configuration for npm.

Checklist

@frederikprijck frederikprijck requested a review from a team as a code owner September 18, 2023 12:37
@Widcket
Copy link
Contributor

Widcket commented Sep 22, 2023

👋🏼 I wouldn't say it's adding back, that npm config was just never there: https://github.com/auth0/react-native-auth0/commits/master/.github/dependabot.yml

@frederikprijck
Copy link
Member Author

frederikprijck commented Sep 22, 2023

@Widcket I believe it was enabled by default because of the lack of dependabot file. Now that we have the dependabot file, without an npm configuration, it's no longer enabled and we won't be getting dependabot PRs anymore like we did before. It should only be getting github action updates now.

@Widcket
Copy link
Contributor

Widcket commented Sep 22, 2023

Thanks, wasn't aware that it was enabled by default (where?).

@frederikprijck
Copy link
Member Author

I am not aware where that default is defined, but I noticed dependabot stopped opening PRs once we added this file in different repositories. Once I merged this change in repos like SPA-JS and Angular, dependabot kicked in again.

@poovamraj poovamraj merged commit e7ee04d into master Sep 22, 2023
5 checks passed
@poovamraj poovamraj deleted the frederikprijck-patch-1 branch September 22, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants