Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user_id_attribute support to AzureAD connection options in Connection Manager #445

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

acwest
Copy link
Contributor

@acwest acwest commented Sep 19, 2024

🔧 Changes

  • Add Support for UserIDAttribute to ConnectionOptionsAzureAD

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@acwest acwest requested a review from a team as a code owner September 19, 2024 16:59
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.71%. Comparing base (86c7e2f) to head (790b84f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files          49       49           
  Lines        8207     8211    +4     
=======================================
+ Hits         7855     7859    +4     
  Misses        235      235           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acwest acwest force-pushed the ESD-40358-add-user-id-attribute-to-azureAD branch from 2a1d7df to 790b84f Compare September 19, 2024 17:13
@developerkunal developerkunal changed the title Add userID attribute type for AzureAD connections Add user_id_attribute support to AzureAD connection options in Connection Manager Sep 19, 2024
@acwest acwest merged commit 720c3a0 into main Sep 20, 2024
9 checks passed
@acwest acwest deleted the ESD-40358-add-user-id-attribute-to-azureAD branch September 20, 2024 13:11
@developerkunal developerkunal mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants