Skip to content

Commit

Permalink
Merge pull request #98 from auth0/more-xmldoc
Browse files Browse the repository at this point in the history
More missing xml docs
  • Loading branch information
damieng authored Sep 30, 2019
2 parents f50074e + ea4b66c commit e1d5f32
Show file tree
Hide file tree
Showing 5 changed files with 383 additions and 361 deletions.
10 changes: 9 additions & 1 deletion src/Auth0.OidcClient.Android/AndroidBrowserBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,14 @@ namespace Auth0.OidcClient
/// </summary>
public abstract class AndroidBrowserBase : IBrowser
{
/// <summary>
/// The <see cref="Context"/> associated with this browser.
/// </summary>
protected Context context;

/// <summary>
/// Whether this browser should launch a new Android Task.
/// </summary>
protected bool IsNewTask;

/// <summary>
Expand Down Expand Up @@ -58,7 +65,8 @@ void Callback(string response)
/// <summary>
/// Open a web browser with the given uri.
/// </summary>
/// <param name="uri">The uri address to open in the browser.</param>
/// <param name="uri"><see cref="Uri"/> address to open in the browser.</param>
/// <param name="context">Optional <see cref="Context"/> associated with the browser.</param>
protected abstract void OpenBrowser(Android.Net.Uri uri, Context context = null);
}
}
1 change: 1 addition & 0 deletions src/Auth0.OidcClient.Android/AutoSelectBrowser.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Android.Content;
using IdentityModel.OidcClient.Browser;

namespace Auth0.OidcClient
{
Expand Down
7 changes: 6 additions & 1 deletion src/Auth0.OidcClient.Android/SystemBrowser.cs
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
using Android.Content;
using IdentityModel.OidcClient.Browser;

namespace Auth0.OidcClient
{
/// <summary>
/// Implements browser integration using the a regular web browser.
/// Implements the <see cref="IBrowser"/> interface using the best available option for the current Android version.
/// </summary>
public class SystemBrowser : AndroidBrowserBase
{
/// <summary>
/// Create a new instance of <see cref="SystemBrowser"/> for a given <see cref="Context"/>.
/// </summary>
/// <param name="context"><see cref="Context"/> provided to any subsequent callback.</param>
public SystemBrowser(Context context = null)
: base(context)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace Auth0.OidcClient
/// </summary>
public class ASWebAuthenticationSessionBrowser : IOSBrowserBase
{
/// <inheritdoc/>
protected override Task<BrowserResult> Launch(BrowserOptions options)
{
return Launch(options);
Expand Down
Loading

1 comment on commit e1d5f32

@anworcs
Copy link

@anworcs anworcs commented on e1d5f32 Oct 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/Auth0.OidcClient.Android/AndroidBrowserBase.cs

Please sign in to comment.