Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rich consents #122

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

cgcladeraokta
Copy link

@cgcladeraokta cgcladeraokta commented Dec 10, 2024

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Adds fetch rich consent record capability to guardian sdk.

References

Testing

  1. Run the sample app
  2. Enroll to MFA
  3. Initiate a CIBA authentication request for the enrolled user
  4. Verify the consent details are displayed
  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@cgcladeraokta cgcladeraokta marked this pull request as ready for review December 11, 2024 14:27
README.md Outdated
if (exception instanceof GuardianException) {
GuardianException guardianException = (GuardianException) exception;
if (guardianException.isResourceNotFound()) {
// there is no consent associated with the tranaction

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: transaction

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting these. I fixed this and the rest of typos in 6eea956

README.md Outdated
@@ -178,23 +178,54 @@ guardian
.execute(); // or start(new Callback<> ...) asynchronously
```

### Fetch rich consent details

When you receive a push notification, the presence of the property `tranactionLinkingId` indicates a

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: transactionLinkingId

README.md Outdated
### Fetch rich consent details

When you receive a push notification, the presence of the property `tranactionLinkingId` indicates a
rich consent record may be associated to the tranaction.
Copy link

@sam-muncke sam-muncke Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo:transaction

README.md Outdated
To fetch the rich consent details, you can use the `fetchConsent` method.

```java
if (notification.getTranactionLinkingId() != null) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: getTransactionLinkingId

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants