Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFA-2681] Add advanced telemetry to SDK #113

Merged
merged 4 commits into from
Mar 15, 2024
Merged

[MFA-2681] Add advanced telemetry to SDK #113

merged 4 commits into from
Mar 15, 2024

Conversation

andy317fe301f8c7
Copy link
Contributor

@andy317fe301f8c7 andy317fe301f8c7 commented Feb 6, 2024 •
edited
Loading

Description

SDK should allow for an additional telemetry info that will be sent in requests to mfa-api. If not provided, a default value is set.

References

https://auth0team.atlassian.net/browse/MFA-2681

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

shadow-dahm
shadow-dahm suggested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@shadow-dahm shadow-dahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, and can we please cover the extra constructors and paths with test cases?

guardian/src/main/java/com/auth0/android/guardian/sdk/Guardian.java Show resolved Hide resolved
shadow-dahm
shadow-dahm approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@shadow-dahm shadow-dahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra tests appear to cover, thanks!

@ionutmanolache-okta ionutmanolache-okta merged commit 1eb0d5c into master Mar 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandrozerov-okta oleksandrozerov-okta oleksandrozerov-okta approved these changes

@shadow-dahm shadow-dahm shadow-dahm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy317fe301f8c7 @shadow-dahm @oleksandrozerov-okta @ionutmanolache-okta