Fix logging and output of variables #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unlimited plan:
- currently does not `core.info` log the outputs
- sets the `remaining` output to `unlimited` but does not update the
corresponding variable - this causes the output to later on be overridden
with 0
- limited plan:
- instead of assigning to the `remaining` and `percentage` variables from the
parent scope, redefines them as consts in the current scope -
`core.setOutput` in the parent scope thus always sets outputs to 0, 0.
niklasfaschingmoia
force-pushed
the
fix-outputs
branch
from
8b6dae2 to
6c791a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core.infolog the outputsremainingoutput tounlimitedbut does not update the corresponding variable - this causes the output to later on be overridden with 0remainingandpercentagevariables from the parent scope, redefines them as consts in the current scope -core.setOutputin the parent scope thus always sets outputs to 0, 0.