Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename my-app to app round 2 #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rename my-app to app round 2 #90

wants to merge 1 commit into from

Conversation

brandonseydel
Copy link
Member

No description provided.

@3cp
Copy link
Member

3cp commented Jan 19, 2023

As discussed before, <app> does not work if user chooses ShadowDOM setup (the spec requires at least a dash in tag name).

@brandonseydel
Copy link
Member Author

brandonseydel commented Jan 19, 2023 •
edited
Loading

@3cp - Shadows dont require a - but it requires it of a non standard tag....maybe a div with app....or just make it something more production ready other than my-app or just leave it app as that is 99% of users first sequence of events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonseydel @3cp