Changes to get crosscompile working #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_doserrno relies on crt100, mingw probably doesnt want to use that (though it can). Expect it will map to the desired crt when using VC++
|
Great. I like this. I intend to accept/merge it after Audacity 2.1.3 is released. |
| @@ -1185,15 +1185,14 @@ wxRenameFile(const wxString& file1, const wxString& file2, bool overwrite) | |||
| // For explanation, see: (warning...based mostly on observed behavior) | |||
| // http://bugzilla.audacityteam.org/show_bug.cgi?id=1266 | |||
| // https://github.com/audacity/audacity/pull/94 | |||
| unsigned long doserrno = 0; | |||
| errno = 0; | |||
There was a problem hiding this comment.
This does not seems possible to me, errno is a macro, not a variable.
The code should be probably changed to:
_set_errno(0)
See:
https://docs.microsoft.com/en-us/cpp/c-runtime-library/errno-doserrno-sys-errlist-and-sys-nerr?view=vs-2019
EDIT: this line should probably moved to line 1191, before calling wxRename(), since errno does not get cleared on success.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo in configure.in fixed and use errno instead of doserrno, the former is more compatible (no msvc dependency).