Install recipes only for deployer 6 and earlier#11
Install recipes only for deployer 6 and earlier#11yuriystovbur wants to merge 1 commit intoatymic:masterfrom
Conversation
| } | ||
|
|
||
| const getInstalledDeployerMajorVersion = async (): Promise<number|null> => { | ||
| const {stdout} = await execa('composer', ['global', 'show', 'deployer/deployer']); |
There was a problem hiding this comment.
I don't think this will work correctly, since this is performed in an action, it won't e installed yet.
There was a problem hiding this comment.
oh, dw I see this is done after install.
| @@ -15,6 +25,16 @@ export default async (options: DeployerOptions): Promise<void> => { | |||
|
|
|||
| await execa('composer', ['global', 'require', deployerPackage]); | |||
There was a problem hiding this comment.
We're also going to need to install the correct deployer package. I think we should check the passed version string and then install only deployer if it's >= v7, otherwise install v6 + recipes
There was a problem hiding this comment.
Deployer version is checked after it is installed. Based on this, a decision is made to install recipes.
And now deployer latest version = 6 - recipies will be installed.
Deployer v7 will be installed without recipes.
There was a problem hiding this comment.
The issue is there will be breaking changes between the versions. We need to know what version the user is using, rather than what the latest is.
2 participants
Reverted to the deployer/recipes package installation.
Fix for issue #10