build: remove legacy Apple SDK frameworks #2885
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to nixos.org[^1], the `darwin.apple_sdk` frameworks have been stubs for some time, and are now removed. Evaluating `atuin` on darwin on `nixpkgs-unstable` results in the following evaluation error: ``` error: darwin.apple_sdk_11_0 has been removed as it was a legacy compatibility stub; see <https://nixos.org/manual/nixpkgs/stable/#sec-darwin-legacy-frameworks> for migration instructions ``` According to those linked docs, the fix is to remove references to these SDKs, which will not have any other effect since they were stubs anyway. [^1]: https://nixos.org/manual/nixpkgs/stable/#sec-darwin-legacy-frameworks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your work on atuin! I've loved using it over the past year.
According to nixos.org1, the
darwin.apple_sdkframeworks have been stubs for some time, and are now removed. Evaluatingatuinon darwin onnixpkgs-unstableresults in the following evaluation error:According to those linked docs, the fix is to remove references to these SDKs, which will not have any other effect since they were stubs anyway.
Checks
Footnotes
https://nixos.org/manual/nixpkgs/stable/#sec-darwin-legacy-frameworks ↩